On 12/01/2022 14:41:42-0500, Nícolas F. R. A. Prado wrote: > The timeout setting for the rtc kselftest is currently 90 seconds. This > setting is used by the kselftest runner to stop running a test if it > takes longer than the assigned value. > > However, two of the test cases inside rtc set alarms. These alarms are > set to the next beginning of the minute, so each of these test cases may > take up to, in the worst case, 60 seconds. > > In order to allow for all test cases in rtc to run, even in the worst > case, when using the kselftest runner, the timeout value should be > increased to at least 120. Set it to 180, so there's some additional > slack. > > Correct operation can be tested by running the following command right > after the start of a minute (low second count), and checking that all > test cases run: > > ./run_kselftest.sh -c rtc > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > --- > > Changes in v2: > - Expanded commit message to make the issue, and how to test the fix, clearer > > v1: https://lore.kernel.org/all/20220112165359.3206047-1-nfraprado@xxxxxxxxxxxxx/ > > tools/testing/selftests/rtc/settings | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/rtc/settings b/tools/testing/selftests/rtc/settings > index ba4d85f74cd6..a953c96aa16e 100644 > --- a/tools/testing/selftests/rtc/settings > +++ b/tools/testing/selftests/rtc/settings > @@ -1 +1 @@ > -timeout=90 > +timeout=180 > -- > 2.34.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
