From: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
The rc variable doesn't need to be tested a second time when the <if> block
evaluates to false.
Signed-off-by: Hugo Villeneuve <hvilleneuve@xxxxxxxxxxxx>
---
drivers/rtc/rtc-isl1208.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c
index 182dfa605515..c7f04df5a0b6 100644
--- a/drivers/rtc/rtc-isl1208.c
+++ b/drivers/rtc/rtc-isl1208.c
@@ -880,15 +880,17 @@ isl1208_probe(struct i2c_client *client, const struct i2c_device_id *id)
if (rc)
return rc;
- if (client->irq > 0)
+ if (client->irq > 0) {
rc = isl1208_setup_irq(client, client->irq);
- if (rc)
- return rc;
+ if (rc)
+ return rc;
+ }
- if (evdet_irq > 0 && evdet_irq != client->irq)
+ if (evdet_irq > 0 && evdet_irq != client->irq) {
rc = isl1208_setup_irq(client, evdet_irq);
- if (rc)
- return rc;
+ if (rc)
+ return rc;
+ }
rc = devm_rtc_nvmem_register(isl1208->rtc, &isl1208->nvmem_config);
if (rc)
--
2.30.2
