On Tue, Sep 28, 2021 at 8:42 PM John Stultz <john.stultz@xxxxxxxxxx> wrote: > > On Tue, Sep 28, 2021 at 4:56 PM Will McVicker <willmcvicker@xxxxxxxxxx> wrote: > > > > This allows modules to access the value of timekeeping_suspended without > > giving them write access to the variable. > > > > It's important to cover "the why" not "the what" in these commit > messages, so you might add a note as to what code will be the user of > this (the samsung/clk-pll.c code changed later in this series). > > thanks > -john Thanks John for the tip. I will try to be better at that in the followup. For this specific patch, I am adding this new API because the Samsung PLL driver (drivers/clk/samsung/clk-pll.c) currently is using the variable 'timekeeping_suspended' to detect timeouts before the clocksource is initialized or timekeeping itself is suspended. My patch series aims to modularize the Samsung PLL driver. So to keep the driver's functionality intact, I need to add this additional API. --Will
