Re: [PATCH] rtc: s5m: Check return value of s5m_check_peding_alarm_interrupt()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/07/2021 07:13, Nobuhiro Iwamatsu wrote:
> s5m_check_peding_alarm_interrupt() in s5m_rtc_read_alarm() gets the return
> value, but doesn't use it.
> This modifies using the s5m_check_peding_alarm_interrupt()"s return value

Avoid "This ..." type of sentences and use simple imperative:
https://elixir.bootlin.com/linux/v5.13/source/Documentation/process/submitting-patches.rst#L89

> as the s5m_rtc_read_alarm()'s return value.
> 
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@xxxxxxxxxxx>
> Cc: linux-samsung-soc@xxxxxxxxxxxxxxx
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@xxxxxxxxxxxxx>
> ---
>  drivers/rtc/rtc-s5m.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>


Best regards,
Krzysztof



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux