Re: [PATCH v7 3/7] mfd: Add base driver for Netronix embedded controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 12, 2021 at 08:36:49PM +0100, Andreas Kemnade wrote:
> On Sat,  9 Jan 2021 19:02:16 +0100
> Jonathan Neuschäfer <j.neuschaefer@xxxxxxx> wrote:
[...]
> > +static const struct of_device_id of_ntxec_match_table[] = {
> > +	{ .compatible = "netronix,ntxec", },
> > +	{}
> > +};
> > +
> MODULE_DEVICE_TABLE?

Yes, good idea.

> > +static struct i2c_driver ntxec_driver = {
> > +	.driver = {
> > +		.name = "ntxec",
> > +		.of_match_table = of_ntxec_match_table,
> > +	},
> > +	.probe_new = ntxec_probe,
> > +	.remove = ntxec_remove,
> > +};
> > +module_i2c_driver(ntxec_driver);
> 
> MODULE_LICENSE()?
> 
> modpost moans about that here.

I forgot those. Thanks for noticing.
I'll add the MODULE_ lines in v8.



Thanks,
Jonathan

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux