On Mon, Dec 07 2020 at 17:05, Jason Gunthorpe wrote: > On Sun, Dec 06, 2020 at 10:46:21PM +0100, Thomas Gleixner wrote: >> static void sync_hw_clock(struct work_struct *work) >> { >> + static unsigned long offset_nsec = NSEC_PER_SEC / 2; > > A comment here explaining this is the default: because the platform is > assumed to use CMOS, and by the way, this whole thing is obsolete > don't use it, seems appropriate.. Will add something like that. > The time split is clearer if you think of it from a bus/datasheet > perspective, less clear if you try to measure the system directly, eg > from an alarm. But, I think this has a better chance of some rtclib > driver authors to fill in the datasheet value at least. That's the hope. You know hope dies last... Thanks, tglx