On Fri, 27 Nov 2020, Bartosz Golaszewski wrote: > On Fri, Nov 27, 2020 at 10:16 AM Lee Jones <lee.jones@xxxxxxxxxx> wrote: > > > > > > > > On Mon, 9 Nov 2020 at 16:34, Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > >> > >> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > >> > >> rtc_register_device() is a managed interface but it doesn't use devres > >> by itself - instead it marks an rtc_device as "registered" and the devres > >> callback for devm_rtc_allocate_device() takes care of resource release. > >> > >> This doesn't correspond with the design behind devres where managed > >> structures should not be aware of being managed. The correct solution > >> here is to register a separate devres callback for unregistering the > >> device. > >> > >> While at it: rename rtc_register_device() to devm_rtc_register_device() > >> and add it to the list of managed interfaces in devres.rst. This way we > >> can avoid any potential confusion of driver developers who may expect > >> there to exist a corresponding unregister function. > >> > >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> > >> --- > >> .../driver-api/driver-model/devres.rst | 1 + > >> arch/alpha/kernel/rtc.c | 2 +- > >> drivers/mfd/menelaus.c | 2 +- > > > > > > This patch should have been sent to and Acked by MFD too. > > > > Sorry Lee, I missed the fact that there were changes outside of > drivers/rtc/. Other than skipping the MFD maintainer - do you see > anything wrong in that bit? No real harm done. The patch looks fine from an MFD standpoint. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
