On Tue, Nov 17, 2020 at 1:10 PM Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote: > > On Tue, Nov 17, 2020 at 9:39 AM johannes-hahn@xxxxxxxxxxx > <johannes-hahn@xxxxxxxxxxx> wrote: > > > > Hello Andy, > > > > when comparing the ACPI IDs used in rtc-ds1307.c, which is already on mainline > > > > https://elixir.bootlin.com/linux/latest/source/drivers/rtc/rtc-ds1307.c#L1141 > > > > for example. Every ID listed there is also not formatted the ACPI ID , PNP ID way defined in the ACPI spec. > > > > How about that ? > > Bad examples should not prevent you from doing the right thing, correct? > > JFYI: https://lore.kernel.org/linux-rtc/20201116142859.31257-1-andriy.shevchenko@xxxxxxxxxxxxxxx/ Moreover, this seems to be the last driver which was broken by the same guy who "invented" ACPI IDs for them. The rest had been reverted already. -- With Best Regards, Andy Shevchenko
