On 16/11/2020 16:43:43+0200, Andy Shevchenko wrote: > On Thu, Nov 12, 2020 at 02:07:32PM +0100, Claudius Heine wrote: > > The RX6110 also supports I2C, so this patch adds support for it to the > > driver. > > > > This also renames the SPI specific functions and variables to include > > `_spi_` in their names. > > As practice shows this is not the best approach. Can you ratqer split it to > three modules: core, spi, i2c like it's done in many other cases (esp. IIO)? > Actually, I'm fine with having everytihn in the same file because separating everything out means having 3 more files per rtc supporting both busses in an already very crowded folder. And I don't think being able to remove support for one or the other holds any actual value. > In Kconfig you just leave same option with two additional ones like > > config ..._SPI > tristate > default SPI_MASTER > depends on SPI_MASTER > > config ..._I2C > tristate > default I2C > depends on I2C > > -- > With Best Regards, > Andy Shevchenko > > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
