Hi, Thank you for the patch. On 14/11/2020 12:18:21+0800, Youling Tang wrote: > When rtc->base or rtc->int_osc or rtc->losc or rtc->ext_losc is NULL, > we should free clk_data and rtc before the function returns to prevent > memleak. > I think this is fixed by 28d211919e422f58c1e6c900e5810eee4f1ce4c8 in my branch: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?id=28d211919e422f58c1e6c900e5810eee4f1ce4c8 -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com