Hi, On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote: > On 30/03/2020 20:26:16+0800, Biwen Li wrote: > > From: Biwen Li <biwen.li@xxxxxxx> > > > > Add shutdown interface > > > > Signed-off-by: Biwen Li <biwen.li@xxxxxxx> > > --- > > drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/drivers/rtc/rtc-fsl-ftm-alarm.c b/drivers/rtc/rtc-fsl-ftm-alarm.c > > index d7fa6c16f47b..118a775e8316 100644 > > --- a/drivers/rtc/rtc-fsl-ftm-alarm.c > > +++ b/drivers/rtc/rtc-fsl-ftm-alarm.c > > @@ -307,6 +307,15 @@ static int ftm_rtc_probe(struct platform_device *pdev) > > return 0; > > } > > > > +static void ftm_rtc_shutdown(struct platform_device *pdev) > > +{ > > + struct ftm_rtc *rtc = platform_get_drvdata(pdev); > > + > > + ftm_irq_acknowledge(rtc); > > + ftm_irq_disable(rtc); > > + ftm_clean_alarm(rtc); > > If the alarm is able to start the platform, then you probably don't want > to disable the alarm on shutdown. > I realise you never replied to that question. Is that patch still of interest? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com