On Thu, Sep 14, 2020 at 22:36, Rob Herring <robh@xxxxxxxxxx> wrote:
> -----Original Message-----
> From: Rob Herring <robh@xxxxxxxxxx>
> Sent: 2020年9月14日 22:36
> To: Qiang Zhao <qiang.zhao@xxxxxxx>
> Cc: a.zummo@xxxxxxxxxxxx; alexandre.belloni@xxxxxxxxxxx;
> linux-rtc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/3] dt-bindings: rtc-2127: Add bindings for
> nxp,rtc-2127.txt
>
> > > > > >
> >
> > Please help to review as below, if it is ok, I will send the new version patch.
> Thank you!
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > new file mode 100644
> > index 0000000..809dd59
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/rtc/nxp,pcf2127.yaml
> > @@ -0,0 +1,38 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings please:
> > +
> > +title: PCF RTCs
> > +
> > +maintainers:
> > + - Qiang Zhao <qiang.zhao@xxxxxxx>
> > +
> > +
> > + no-watchdog:
> > + maxItems: 1
>
> maxItems is for arrays. What's the type here? It should have a description too.
Is it ok as below?
no-watchdog:
$ref: /schemas/types.yaml#/definitions/flag
description:
With this property, the device will not registered as a watchdog device.
> > >
> > > Documentation/devicetree/writing-schema.rst and about 1000 examples
> > > in the kernel tree.
> > >
> > > Rob
Best Regards
Qiang Zhao
