Re: [PATCH] rtc: interface:: 1969-12-31T23:59:59 is set as rtc_time if rtc_time is invalid in __rtc_read_time

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 01/08/2020 19:20:07+0800, Grant Feng wrote:
> 1969-12-31T23:59:59 is an error more clear than Invalid argument

Definitively not, 1969-12-31T23:59:59 is a valid date and should not be
returned when it is known the current date is not set in the RTC.

> 
> For example, when the RTC clock is not set, it will print a kernel
> error log every time someone tries to read the clock:
>         ~ # hwclock -r
>         hwclock: RTC_RD_TIME: Invalid argument
> 
> It's clear and easy to understand what happened if print
> 1969-12-31T23:59:59 in this situation:
>         ~ # hwclock -r
>         Wed Dec 31 23:59:59 1969  0.000000 seconds
> 

How do you know this is an error an not what is actually set on the RTC?

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux