On 20/07/2020 10:44:41+0000, Johnson CH Chen (陳昭勳) wrote: > Hi Alexandre, > > > > v4->v5: > > > - Fix reported build error by replacing RTC_DRV_DS1374_WDT with > > > WATCHDOG_CORE > > > > > > > This is not the correct solution as this will remove the alarm functionality for > > anyone enabling WATCHDOG. I already submitted a proper fix. > > > > It's an appropriate and better solution. Thanks! > > RTC_DRV_DS1374_WDT still should select WATCHDOG_CORE to avoid build error if WATCHDOG_CORE is set to "m", and it should be depended on RTC_DRV_DS1374 and WATCHDOG. > My patch handles that properly, RTC_DRV_DS1374_WDT still selects WATCHDOG_CORE -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
