On Fri, 2020-04-17 at 16:29 +0800, Ran Bi wrote:
> On Thu, 2020-04-16 at 10:14 +0100, Lee Jones wrote:
> > On Wed, 08 Apr 2020, Hsin-Hsiung Wang wrote:
> >
> > > From: Ran Bi <ran.bi@xxxxxxxxxxxx>
> > >
> > > This add support for the MediaTek MT6358 RTC. Driver using
> > > compatible data to store different RTC_WRTGR address offset.
> > > This replace RTC_WRTGR to RTC_WRTGR_MT6323 in mt6323-poweroff
> > > driver which only needed by armv7 CPU without ATF.
> > >
> > > Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> > > Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> > > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> > > Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
> > > Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
> > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
> >
> > Please place these in chronological order. They should provide some
> > history, rather than a unordered slab list of random sign-offs.
> >
>
> I suppose that you mean the order should be like below, right?
> Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
> Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
> Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
> Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
>
Correction, I think following is the correct chronological order:
Signed-off-by: Ran Bi <ran.bi@xxxxxxxxxxxx>
Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@xxxxxxxxxxxx>
Reviewed-by: Nicolas Boichat <drinkcat@xxxxxxxxxxxx>
Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
Acked-by: Sebastian Reichel <sre@xxxxxxxxxx>
Reviewed-by: Yingjoe Chen <yingjoe.chen@xxxxxxxxxxxx>
> > > ---
> > > drivers/power/reset/mt6323-poweroff.c | 2 +-
> > > drivers/rtc/rtc-mt6397.c | 18 +++++++++++++++---
> > > include/linux/mfd/mt6397/rtc.h | 9 ++++++++-
> > > 3 files changed, 24 insertions(+), 5 deletions(-)
> >
> > [...]
> >
> > > diff --git a/include/linux/mfd/mt6397/rtc.h b/include/linux/mfd/mt6397/rtc.h
> > > index 7dfb63b..6200f3b 100644
> > > --- a/include/linux/mfd/mt6397/rtc.h
> > > +++ b/include/linux/mfd/mt6397/rtc.h
> > > @@ -18,7 +18,9 @@
> > > #define RTC_BBPU_CBUSY BIT(6)
> > > #define RTC_BBPU_KEY (0x43 << 8)
> > >
> > > -#define RTC_WRTGR 0x003c
> > > +#define RTC_WRTGR_MT6358 0x3a
> > > +#define RTC_WRTGR_MT6397 0x3c
> >
> > Why remove the leading 00's?
> >
> > These are now different to the other regs defined in this header.
> >
>
> I will fix this at next patch.
>
> > > +#define RTC_WRTGR_MT6323 RTC_WRTGR_MT6397
> > >
> > > #define RTC_IRQ_STA 0x0002
> >
> > Like here for instance --^
> >
> > > #define RTC_IRQ_STA_AL BIT(0)
> > > @@ -65,6 +67,10 @@
> > > #define MTK_RTC_POLL_DELAY_US 10
> > > #define MTK_RTC_POLL_TIMEOUT (jiffies_to_usecs(HZ))
> > >
> > > +struct mtk_rtc_data {
> > > + u32 wrtgr;
> > > +};
> > > +
> > > struct mt6397_rtc {
> > > struct device *dev;
> > > struct rtc_device *rtc_dev;
> > > @@ -74,6 +80,7 @@ struct mt6397_rtc {
> > > struct regmap *regmap;
> > > int irq;
> > > u32 addr_base;
> > > + const struct mtk_rtc_data *data;
> > > };
> > >
> > > #endif /* _LINUX_MFD_MT6397_RTC_H_ */
> >
>
