Hi Alexandre, On Mon, Mar 16, 2020 at 11:48 AM Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote: > Move SIMPLE_DEV_PM_OPS out of #ifdef to fix build issues when PM_SLEEP is > not selected. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > --- > drivers/rtc/rtc-mt2712.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-mt2712.c b/drivers/rtc/rtc-mt2712.c > index 432df9b0a3ac..c2709c1602f0 100644 > --- a/drivers/rtc/rtc-mt2712.c > +++ b/drivers/rtc/rtc-mt2712.c > @@ -394,10 +394,10 @@ static int mt2712_rtc_resume(struct device *dev) > > return 0; > } > +#endif > > static SIMPLE_DEV_PM_OPS(mt2712_pm_ops, mt2712_rtc_suspend, > mt2712_rtc_resume); That's 23 more unused pointers in your kernel image. > -#endif > > static const struct of_device_id mt2712_rtc_of_match[] = { > { .compatible = "mediatek,mt2712-rtc", }, Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds