Re: [PATCH] rtc: zynqmp: Add calibration set and get support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Srinivas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on next-20200224]
[cannot apply to v5.6-rc3]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Neeli/rtc-zynqmp-Add-calibration-set-and-get-support/20200222-053755
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: c6x-randconfig-a001-20200225 (attached as .config)
compiler: c6x-elf-gcc (GCC) 7.5.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.5.0 make.cross ARCH=c6x 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-zynqmp.o: In function `xlnx_rtc_read_offset':
>> drivers/rtc/rtc-zynqmp.c:198: undefined reference to `__c6xabi_divlli'
>> drivers/rtc/rtc-zynqmp.c:198: undefined reference to `__c6xabi_divlli'
   drivers/rtc/rtc-zynqmp.o: In function `xlnx_rtc_set_offset':
   drivers/rtc/rtc-zynqmp.c:223: undefined reference to `__c6xabi_divlli'
   drivers/rtc/rtc-zynqmp.c:223: undefined reference to `__c6xabi_divlli'

vim +198 drivers/rtc/rtc-zynqmp.c

   192	
   193	static int xlnx_rtc_read_offset(struct device *dev, long *offset)
   194	{
   195		struct xlnx_rtc_dev *xrtcdev = dev_get_drvdata(dev);
   196		long offset_val;
   197		unsigned int reg;
 > 198		unsigned int tick_mult = RTC_PPB / xrtcdev->calibval;
   199	
   200		reg = readl(xrtcdev->reg_base + RTC_CALIB_RD);
   201	
   202		/* Offset with seconds ticks */
   203		offset_val = reg & RTC_TICK_MASK;
   204		offset_val = offset_val - xrtcdev->calibval;
   205		offset_val = offset_val * tick_mult;
   206	
   207		/* Offset with fractional ticks */
   208		if (reg & RTC_FR_EN)
   209			offset_val += ((reg & RTC_FR_MASK) >> RTC_FR_DATSHIFT)
   210				* (tick_mult / RTC_FR_MAX_TICKS);
   211		*offset = offset_val;
   212	
   213		return 0;
   214	}
   215	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux