Replace cros_ec_cmd_xfer_status() with cros_ec_send_cmd_msg() which does the message buffer setup and cleanup. Signed-off-by: Prashant Malani <pmalani@xxxxxxxxxxxx> --- drivers/rtc/rtc-cros-ec.c | 27 ++++++++------------------- 1 file changed, 8 insertions(+), 19 deletions(-) diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c index d043d30f05bc1d..113638a82e2c0c 100644 --- a/drivers/rtc/rtc-cros-ec.c +++ b/drivers/rtc/rtc-cros-ec.c @@ -34,16 +34,11 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, u32 *response) { int ret; - struct { - struct cros_ec_command msg; - struct ec_response_rtc data; - } __packed msg; - memset(&msg, 0, sizeof(msg)); - msg.msg.command = command; - msg.msg.insize = sizeof(msg.data); + struct ec_response_rtc data = {0}; - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); + ret = cros_ec_send_cmd_msg(cros_ec, 0, command, NULL, 0, + &data, sizeof(data)); if (ret < 0) { dev_err(cros_ec->dev, "error getting %s from EC: %d\n", @@ -52,7 +47,7 @@ static int cros_ec_rtc_get(struct cros_ec_device *cros_ec, u32 command, return ret; } - *response = msg.data.time; + *response = data.time; return 0; } @@ -61,17 +56,11 @@ static int cros_ec_rtc_set(struct cros_ec_device *cros_ec, u32 command, u32 param) { int ret = 0; - struct { - struct cros_ec_command msg; - struct ec_response_rtc data; - } __packed msg; + struct ec_response_rtc data; - memset(&msg, 0, sizeof(msg)); - msg.msg.command = command; - msg.msg.outsize = sizeof(msg.data); - msg.data.time = param; - - ret = cros_ec_cmd_xfer_status(cros_ec, &msg.msg); + data.time = param; + ret = cros_ec_send_cmd_msg(cros_ec, 0, command, &data, sizeof(data), + NULL, 0); if (ret < 0) { dev_err(cros_ec->dev, "error setting %s on EC: %d\n", command == EC_CMD_RTC_SET_VALUE ? "time" : "alarm", -- 2.25.0.341.g760bfbb309-goog