On 08/01/2020 16:40, Thomas Gleixner wrote: >> [...] >> I think you may ask for Thomas' opinion (Cc'ed now). > > I'm a bit wary with binding this to the fact that the HPET is > involved. > > Especially I don't know whether the Surface3 which is Intel based > exposes the HPET via ACPI which would pretty much revert the effect of > the mentioned commit which introduced the IRQF_SHARED magic especially > for Surface3. > > As this is a Surface3 specific misfeature, it might be trivial enough to > set IRQF_SHARED based on a DMI quirk for the Surface3. > > Thanks, > > tglx Thanks Andy and Thomas for the discussion. If I understood correctly, Thomas' opinion is that we shouldn't keep the IRQ flag as shared and instead pursue a device's quirk for Surface3 in order of making IRQs shared only in such laptop - correct? In that case, shall we revert that commit entirely (I can respin the patch fixing the description and reverting, if that's the case), or this version (HPET-restricted) is enough? I don't have a Surface 3 on hands, if anybody can provide SMBIOS data from it, I can also take a look on quirking it to keep the shared IRQs. Cheers, Guilherme
