On 04/12/2019 23:57:31+0100, Linus Walleij wrote: > The current use of mode flags to us SPI_MODE_3 and > SPI_CS_HIGH is fragile: it overwrites anything already > assigned by the SPI core. Change it thusly: > > - Just |= the SPI_MODE_3 so we keep other flags > - Assign ^= SPI_CS_HIGH since we might be active high > already, and that is usually the case with GPIOs used > for chip select, even if they are in practice active low. > > Add a comment clarifying why ^= SPI_CS_HIGH is the right > choice here. > > Reported-by: Mark Brown <broonie@xxxxxxxxxx> > Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> > --- > drivers/rtc/rtc-ds1343.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
