Hi Alexandre,
On 16/10/19 22:14, Alexandre Belloni wrote:
> The RTC core now has error messages in case of registration failure, there
> is no need to have other messages in the drivers.
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx>
That makes totally sense for me.
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx>
> ---
> drivers/rtc/rtc-cros-ec.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cros-ec.c b/drivers/rtc/rtc-cros-ec.c
> index 6909e01936d9..da209d00731e 100644
> --- a/drivers/rtc/rtc-cros-ec.c
> +++ b/drivers/rtc/rtc-cros-ec.c
> @@ -351,11 +351,8 @@ static int cros_ec_rtc_probe(struct platform_device *pdev)
> cros_ec_rtc->rtc = devm_rtc_device_register(&pdev->dev, DRV_NAME,
> &cros_ec_rtc_ops,
> THIS_MODULE);
> - if (IS_ERR(cros_ec_rtc->rtc)) {
> - ret = PTR_ERR(cros_ec_rtc->rtc);
> - dev_err(&pdev->dev, "failed to register rtc device\n");
> - return ret;
> - }
> + if (IS_ERR(cros_ec_rtc->rtc))
> + return PTR_ERR(cros_ec_rtc->rtc);
>
> /* Get RTC events from the EC. */
> cros_ec_rtc->notifier.notifier_call = cros_ec_rtc_event;
>
