Hi Guenter
Thanks for the quick review.
Den tir. 13. aug. 2019 kl. 18.19 skrev Guenter Roeck <linux@xxxxxxxxxxxx>:
>
> On Tue, Aug 13, 2019 at 05:35:59PM +0200, Bruno Thomsen wrote:
> > +static int pcf2127_wdt_start(struct watchdog_device *wdd)
> > +{
> > + dev_info(wdd->parent, "watchdog enabled\n");
> > +
> > + return pcf2127_wdt_ping(wdd);
> > +}
> > +
> > +static int pcf2127_wdt_stop(struct watchdog_device *wdd)
> > +{
> > + struct pcf2127 *pcf2127 = watchdog_get_drvdata(wdd);
> > +
> > + dev_info(wdd->parent, "watchdog disabled\n");
> > +
>
> There is a lot of noise in this driver. Please reconsider.
Would it be better if I remove the following lines:
dev_info(wdd->parent, "watchdog enabled\n");
dev_info(wdd->parent, "watchdog disabled\n");
dev_err(dev, "%s: watchdog registering failed\n", __func__);
and change this line to a dev_dbg():
dev_info(wdd->parent, "new watchdog timeout: %is (old: %is)\n",
new_timeout, wdd->timeout);
?
Just checking so I don't waste your time on v3 review.
/Bruno
