On Mon, 29 Jul 2019, Frank Wunderlich wrote: > From: Josef Friedl <josef.friedl@xxxxxxxx> > > add mt6323-rtc and mt6323-pwrc to mt6397 mfd DT bindings > an example is shown in mt6323-poweroff.txt > > changes since v2: separated rtc-mt6397.txt to part 2 > > Suggested-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > Signed-off-by: Josef Friedl <josef.friedl@xxxxxxxx> > Signed-off-by: Frank Wunderlich <frank-w@xxxxxxxxxxxxxxx> > --- > .../devicetree/bindings/mfd/mt6397.txt | 10 +++++++++- > .../bindings/power/reset/mt6323-poweroff.txt | 20 +++++++++++++++++++ > 2 files changed, 29 insertions(+), 1 deletion(-) > create mode 100644 Documentation/devicetree/bindings/power/reset/mt6323-poweroff.txt > > diff --git a/Documentation/devicetree/bindings/mfd/mt6397.txt b/Documentation/devicetree/bindings/mfd/mt6397.txt > index 0ebd08af777d..44acb9827716 100644 > --- a/Documentation/devicetree/bindings/mfd/mt6397.txt > +++ b/Documentation/devicetree/bindings/mfd/mt6397.txt > @@ -8,6 +8,7 @@ MT6397/MT6323 is a multifunction device with the following sub modules: > - Clock > - LED > - Keys > +- Power controller > > It is interfaced to host controller using SPI interface by a proprietary hardware > called PMIC wrapper or pwrap. MT6397/MT6323 MFD is a child device of pwrap. > @@ -22,8 +23,10 @@ compatible: "mediatek,mt6397" or "mediatek,mt6323" > Optional subnodes: > > - rtc > - Required properties: > + Required properties: Should be one of follows > + - compatible: "mediatek,mt6323-rtc" > - compatible: "mediatek,mt6397-rtc" > + For details, see Documentation/devicetree/bindings/rtc/rtc-mt6397.txt Please use relative paths. E.g: ../bindings/rtc/rtc-mt6397.txt Apart from that, the MFD parts look okay to me. For my own reference: Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
