Hi Nick, Missatge de Nick Crews <ncrews@xxxxxxxxxxxx> del dia dv., 8 de febr. 2019 a les 17:10: > > Hi Enric and Alexandre, > > On Fri, Feb 8, 2019 at 5:18 AM Enric Balletbo i Serra > <enric.balletbo@xxxxxxxxxxxxx> wrote: > > > > Hi, > > > > On 8/2/19 2:23, Nick Crews wrote: > > > This Embedded Controller has an internal RTC that is exposed > > > as a standard RTC class driver with read/write functionality. > > > > > > The driver is added to the drivers/rtc/ so that the maintainer of that > > > directory will be able to comment on this change, as that maintainer is > > > the expert on this system. In addition, the driver code is called > > > indirectly after a corresponding device is registered from core.c, > > > as opposed to core.c registering the driver callbacks directly. > > > > > > To test: > > >> hwclock --show --rtc /dev/rtc1 > > > 2007-12-31 16:01:20.460959-08:00 > > >> hwclock --systohc --rtc /dev/rtc1 > > >> hwclock --show --rtc /dev/rtc1 > > > 2018-11-29 17:08:00.780793-08:00 > > > > > >> hwclock --show --rtc /dev/rtc1 > > > 2007-12-31 16:01:20.460959-08:00 > > >> hwclock --systohc --rtc /dev/rtc1 > > >> hwclock --show --rtc /dev/rtc1 > > > 2018-11-29 17:08:00.780793-08:00 > > > > > > Signed-off-by: Duncan Laurie <dlaurie@xxxxxxxxxx> > > > Signed-off-by: Nick Crews <ncrews@xxxxxxxxxxxx> > > > > I think that you missed :) > > > > Acked-by: Enric Balletbo i Serra <enric.balletbo@xxxxxxxxxxxxx> > > Acked-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > > > Ah, I removed these because this version is a bit different from the > one that you Acked. Do you normally keep those sign-offs > even after making changes that you possibly might not like? > Well, it's right that you did a small change in the core, so to be strict maybe you have reason, but I don't see as a big change so I expected you maintain my tag. Anyway it's not a problem at all, just that at least I expected the Alexandre ack :) [snip] > > > > Alexandre, this specific patch depends on the patches of the series to apply, > > and the first patches of the series also conflicts/depends on some patches > > queued in chrome-platform-5.1 branch [1]. Is it fine with you if I create an > > immutable branch and all go via your tree? Or what do you think? I am new here > > and I am not sure how to manage that. > > > > Thanks, > > Enric > > Let me know if I can help with this. I based this off what I thought was the > most current master, SHA 74e96711e3379fc66630f2a1d184947f80cf2c48. > Was this not the correct commit to base these off of? > Yeah, it's fine, just that I queued recently some changes and I have trivial conflicts in Kconfig and Makefile, nothing that you need to worry. [snip]
