Hi, On 19/01/2019 15:43:32+0100, Martin Blumenstingl wrote: > +static int meson_rtc_probe(struct platform_device *pdev) > +{ > + struct nvmem_config meson_rtc_nvmem_config = { > + .name = "meson-rtc-regmem", > + .word_size = 4, > + .stride = 4, > + .size = 4 * 4, > + .reg_read = meson_rtc_regmem_read, > + .reg_write = meson_rtc_regmem_write, Not much to add but if those registers are battery backed, you could add .type = NVMEM_TYPE_BATTERY_BACKED, -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com