On 20/12/2018 17:36:56+0800, ZhangXiaoxu wrote: > Users may call 'ioctl' and pass a very big value on 'tm->tm_year'. > It can be overflowed in 'int' after add 1900. > In function 'rtc_month_days' and 'mktime64', also treated it as an > 'unsigned' parameter. > > UBSAN: Undefined behaviour in drivers/rtc/rtc-lib.c:103:59 > signed integer overflow: > 2147483647 + 1900 cannot be represented in type 'int' > > UBSAN: Undefined behaviour in drivers/rtc/rtc-lib.c:119:30 > signed integer overflow: > 2147483647 + 1900 cannot be represented in type 'int' > > So, covert it to 'unsigned' explicitly. > > Signed-off-by: ZhangXiaoxu <zhangxiaoxu5@xxxxxxxxxx> > --- > drivers/rtc/rtc-lib.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
