Hi Srinivas, Thanks for the feedback. > Subject: Re: [PATCH v4 1/5] nvmem: check invalid number of bytes in > nvmem_device_{read,write} > > > > On 10/12/18 12:45, Biju Das wrote: > >> Its better to move checks from > >> bin_attr_nvmem_read()/bin_attr_nvmem_write() into > nvmem_reg_read() > >> and nvmem_reg_write(), so its easy to maintain, rather than adding > >> them to each function. > > Initially I also thought the same. But there are some RTC drivers > > which is using nvmem_device interface is not defining "word_size" > member. That is the reason we need to add it in separate function. > > Can you please suggest how to handle the above drivers? > > Word size is optional anyway, in the case where word_size is not specified, > its considered as one byte word_size. Will send V2 for this. Regards, Biju [https://www2.renesas.eu/media/email/unicef.jpg] This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world. We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year. Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.