Re: [PATCH] rtc: hctosys: Add missing range error reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/11/2018 03:48:25+0000, Maciej W. Rozycki wrote:
> Fix an issue with the 32-bit range error path in `rtc_hctosys' where no 
> error code is set and consequently the successful preceding call result 
> from `rtc_read_time' is propagated to `rtc_hctosys_ret'.  This in turn 
> makes any subsequent call to `hctosys_show' incorrectly report in sysfs 
> that the system time has been set from this RTC while it has not.
> 
> Set the error to ERANGE then if we can't express the result due to an 
> overflow.
> 
> Signed-off-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
> Fixes: b3a5ac42ab18 ("rtc: hctosys: Ensure system time doesn't overflow time_t")
> Cc: stable@xxxxxxxxxxxxxxx # 4.17+
> ---
>  drivers/rtc/hctosys.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



[Index of Archives]     [Linux Sound]     [ALSA Users]     [ALSA Devel]     [Linux Audio Users]     [Linux Media]     [Kernel]     [Gimp]     [Yosemite News]     [Linux Media]

  Powered by Linux