On 19/10/2018 13:43:45-0700, Nathan Chancellor wrote: > Clang warns: > > drivers/rtc/rtc-s35390a.c:124:27: warning: implicit conversion from > 'int' to 'char' changes value from 192 to -64 [-Wconstant-conversion] > buf = S35390A_FLAG_RESET | S35390A_FLAG_24H; > ~ ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~ > 1 warning generated. > > Update buf to be an unsigned 8-bit integer, which matches the buf member > in struct i2c_msg. > > https://github.com/ClangBuiltLinux/linux/issues/145 > Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx> > --- > > v1 -> v2: > > * Use u8 instead of unsigned char, as it's clearer that this is an > integer value and it's shorter. > > drivers/rtc/rtc-s35390a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
