On Tue, May 29, 2018 at 11:09:13PM +0530, Jagan Teki wrote: > From: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > > clk-gate core will take bit_idx through clk_register_gate > and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i > is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) > which is wrong and eventually external gate clock is not enabling. > > This patch fixed by passing bit index and the original change > introduced from below commit. > "rtc: sun6i: Add support for the external oscillator gate" > (sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b) > > Fixes: 17ecd246414b ("rtc: sun6i: Add support for the external oscillator > gate") > Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> > --- > Changes for v3: > - add fixes tag > - Cced stable ML > Changes for v2: > - add suffix _OFFSET with macro name to distinguish b/w > register actual values vs offset. > > drivers/rtc/rtc-sun6i.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > <formletter> This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. </formletter>