On Tue, May 29, 2018 at 09:34:25PM +0530, Jagan Teki wrote: > From: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > > clk-gate core will take bit_idx through clk_register_gate > and then do clk_gate_ops by using BIT(bit_idx), but rtc-sun6i > is passing bit_idx as BIT(bit_idx) it becomes BIT(BIT(bit_idx) > which is wrong and eventually external gate clock is not enabling. > > This patch fixed by passing bit index and the original change > introduced from below commit. > "rtc: sun6i: Add support for the external oscillator gate" > (sha1: 17ecd246414b3a0fe0cb248c86977a8bda465b7b) > > Signed-off-by: Michael Trimarchi <michael@xxxxxxxxxxxxxxxxxxxx> > Signed-off-by: Jagan Teki <jagan@xxxxxxxxxxxxxxxxxxxx> I said it in the v1 already, but this should be sent to stable and have a fixes tag. Maxime -- Maxime Ripard, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com