On Tue, 10 Apr 2018 14:07:28 +0200
Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> wrote:
> Hi Nicholas,
>
> I would greatly appreciate a changelog and at least the cover letter
> because it is difficult to grasp how this relates to the previous
> patches you sent to the RTC mailing list.
Yes good point. Basically this change is "standalone" except using
OPAL_BUSY_DELAY_MS define from patch 1. That patch has a lot of
comments about firmware delays I did not think would be too
interesting.
Basically we're adding msleep(10) here, because the firmware can
repeatedly return OPAL_BUSY for long periods, so we want to context
switch and respond to interrupts.
>
> On 10/04/2018 21:49:32+1000, Nicholas Piggin wrote:
> > The OPAL RTC driver does not sleep in case it gets OPAL_BUSY or
> > OPAL_BUSY_EVENT from firmware, which causes large scheduling
> > latencies, up to 50 seconds have been observed here when RTC stops
> > responding (BMC reboot can do it).
> >
> > Fix this by converting it to the standard form OPAL_BUSY loop that
> > sleeps.
> >
> > Fixes ("powerpc/powernv: Add RTC and NVRAM support plus RTAS fallbacks"
> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > Cc: linux-rtc@xxxxxxxxxxxxxxx
> > Signed-off-by: Nicholas Piggin <npiggin@xxxxxxxxx>
> > ---
> > arch/powerpc/platforms/powernv/opal-rtc.c | 8 +++--
> > drivers/rtc/rtc-opal.c | 37 ++++++++++++++---------
>
> From what I understand, the changes in those files are fairly
> independent, they should probably be separated to ease merging.
I'm happy to do that. It's using the same firmware call, so I thought
a single patch would be fine. But I guess the boot call can be
dropped from this patch because it does not not solve the problem
described in the changelog.
Would you be happy for the driver change to be merged via the powerpc
tree? The code being fixed here came from the same original patch as
a similar issue being fixed in the OPAL NVRAM driver so it might be
easier that way.
Thanks,
Nick
