Hi, On Wed, Feb 21, 2018 at 09:55:08PM +0100, Alexandre Belloni wrote: > The RTC core is always calling rtc_valid_tm after the read_time callback. > It is not necessary to call it just before returning from the callback. > > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > --- > drivers/rtc/rtc-cpcap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-cpcap.c b/drivers/rtc/rtc-cpcap.c > index 3a0333e1f21a..a8856f2b9bc2 100644 > --- a/drivers/rtc/rtc-cpcap.c > +++ b/drivers/rtc/rtc-cpcap.c > @@ -119,7 +119,7 @@ static int cpcap_rtc_read_time(struct device *dev, struct rtc_time *tm) > > cpcap2rtc_time(tm, &cpcap_tm); > > - return rtc_valid_tm(tm); > + return 0; > } > > static int cpcap_rtc_set_time(struct device *dev, struct rtc_time *tm) Reviewed-by: Sebastian Reichel <sebastian.reichel@xxxxxxxxxxxxxxx> -- Sebastian
Attachment:
signature.asc
Description: PGP signature
