On Thu, Nov 30, 2017 at 2:36 PM, Patrick Brünn <P.Bruenn@xxxxxxxxxxxx> wrote: >>From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx] >>Sent: Donnerstag, 30. November 2017 09:18 >>> >>>> +/* >>>> + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights >>Reserved. >>>> + */ >>>> + >>>> +/* >>>> + * The code contained herein is licensed under the GNU General Public >>>> + * License. You may obtain a copy of the GNU General Public License >>>> + * Version 2 or later at the following locations: >>>> + * >>>> + * http://www.opensource.org/licenses/gpl-license.html >>>> + * http://www.gnu.org/copyleft/gpl.html >>>> + */ >> >>Exactly! >>And while you are it , you could replace the boilerplate license text >>with the SPDX id. >>-- > > How would a perfect header look like? > Looking at : > git show b24413180f5600bcb3bb70fbed5cf186b60864bd -- drivers/ > and: > git grep SPDX -- Documentation/ > > it could be: > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights > + */ > or: > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights > + */ > > Personally I would prefer: > +/* > + * Copyright (C) 2004-2011 Freescale Semiconductor, Inc. All Rights > + * > + * SPDX-License-Identifier: GPL-2.0 > + */ > > So, is there any guideline? > > To be clear: I don't want to waste anyone's time on this. But as SPDX > was intended for automation, I think it might be good to try having > some common pattern here. > I don't want to start a discussion, so in case there is no guideline I will > just take the /* SPDX */ in firstline version. Patrick: There are several threads on the topic explaining why: Linus made it clear that he wants this, and on the first line: > +// SPDX-License-Identifier: GPL-2.0 Thomas: I tend to prefer as Linus pointed the // style throughout when there is only a license and copyright involved. Here this would mean: > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (c) 2004-2011 Freescale Semiconductor, Inc. All Rights Reserved. What's you take since you wrote the doc for this? And is there still some updates needed for this since your last patch set? Patrick: Side note a trailing "All Rights Reserved." in a copyright statement is never needed, even though customarily cargo culted by everyone, including me. Started in 1910, it become fully obsolete in 2000 thanks to Nicaragua [1] signing the Berne convention. [1] https://en.wikipedia.org/wiki/All_rights_reserved -- Cordially Philippe Ombredanne
