On 30/08/2017 at 09:45:06 +0200, Sean Nyekjær wrote: > > > On 2017-08-29 17:07, Alexandre Belloni wrote: > > Hi Sean, > > > > I know this patch is 7 months old but I never had the time to write a > > proper reply. > > > > This is using a pretty old API. Can you register a proper watchdog using > > the watchdog subsystem (see drivers/watchdog)? Also, please copy the > > watchdog maintainers. > > > > I understand this will require a significant rewrite effort but the > > final code will be quite cleaner. > Hi Alexandre > > I unfortunately don't have access to the hardware anymore... > I think it would be very risky to rewrite the whole code without testing it > :-) > Ok, too bad. :( > Yes this driver is quite hacky in some ways. It could be nice if the > watchdog part for this could be in the driver/watchdog and the rtc part > here. Maybe we could have 2 entries in the devicetree that shared the same > i2c device address. > If you want to go that route, the proper way is to use the MFD subsystem. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
