Hi Russell, On 21/07/2017 at 00:18:31 +0100, Russell King wrote: > Use the devm_* APIs for allocating memory and mapping the memory in > the probe function to relieve the driver from having to deal with > this in the cleanup paths. > > Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxx> > --- > drivers/rtc/rtc-pl031.c | 19 +++++++------------ > 1 file changed, 7 insertions(+), 12 deletions(-) > > diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c > index 0d87b90b1903..5960fbd08b05 100644 > --- a/drivers/rtc/rtc-pl031.c > +++ b/drivers/rtc/rtc-pl031.c > @@ -310,8 +310,6 @@ static int pl031_remove(struct amba_device *adev) > device_init_wakeup(&adev->dev, false); > free_irq(adev->irq[0], ldata); > rtc_device_unregister(ldata->rtc); > - iounmap(ldata->base); > - kfree(ldata); > amba_release_regions(adev); > > return 0; > @@ -322,25 +320,26 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) > int ret; > struct pl031_local *ldata; > struct pl031_vendor_data *vendor = id->data; > - struct rtc_class_ops *ops = &vendor->ops; > + struct rtc_class_ops *ops; This change should probably go in patch 3/4 -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
