On 07/19/2017 02:22 PM, Alexandre Belloni wrote:
Hi,
On 19/07/2017 at 12:44:41 -0700, Mark Salyzyn wrote:
Primary purpose of rtc_show_time is to provide a marker used for
post-mortem Battery and Power analysis. These markers occur at
major discontinuities of time, and thus optionally add a timestamp
to aid the analysis. This function is to be called at a higher
level, and were added because of a lack of current kernel logging
data.
I really think you should drop rtc from the config, function and file
names because this doesn't have any relationship with any RTC stuff.
Agreed and Thanks. In another response, this function has more in common
with a pr_info_show_time() than I previously have accepted. Most of the
rtc part goes away if I follow that thread/idea Leaving the following:
I can just see that you are (ab)using rtc_time64_to_tm because there is
no struct tm or gmtime() in the kernel.
Yes, since we put that part into a separate patch, that can be
punted/accepted on its own, using rtc-lib is a simple concept. The
commit message for that patch should have had your line of sentiment in
it! (even (ab)using message :-) )
-- Mark
