On Mon, Jun 5, 2017 at 7:00 PM, Alexandre Belloni <alexandre.belloni@xxxxxxxxxxxxxxxxxx> wrote: > On 05/06/2017 at 17:57:22 +0200, Heiner Kallweit wrote: >> Make the definition of ds1307_of_match more compact. This makes the >> code better readable and more in line with the definition of >> ds1307_id and ds1307_acpi_ids. >> >> Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> >> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> --- >> v2: >> - no changes >> v3: >> - add reviewed-by > > Well, I don't like it, and I don't think it actually improves > readability. My experience shows that the opposite of this patch is > quite often necessary. The patch is certainly not important and should ideally be last in the series. Is it possible to apply patches 2-4 right off? They seem fairly orthogonal to this one. Yours, Linus Walleij
