Re: [PATCH] Change min/max to float numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2025-02-06 at 12:02 -0300, Rafael Folco wrote:
> On 06/02/25 09:00, Sebastian Andrzej Siewior wrote:
> > On 2025-02-06 06:16:22 [-0300], Rafael Folco wrote:
> > > Make min/max consistent with avg by recording the latency samples
> > > as float numbers instead of integers.
> > 
> > Why?
> 
> - More precise numbers of Max/Min for extreme low latency cases
> - Distinguish zero latency in bucket 001 (us)
> - Distinguish values from upper/lower boundaries in a bucket
> - Clarify confusion on average (round up) vs maximum in the next bucket (casting)

If you want more precision, set --bucket-width to something lower than
1000 ns.  That will cause everything to be reported with ns precision
(though maybe not quite ns accuracy, depending on the hardware).  We
were hesitant to make ns precision the default in case it misleads
people about the accuracy (plus I didn't know if the change might
confuse some tools that consume the output).

I don't see the need to change things here -- and I definitely don't see
the need to hold on to the unit_per_us stuff if we're going to always
print ns resolution, regardless of whether we use fp.

-Crystal






[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux