Re: [PATCH] Change min/max to float numbers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2025-02-06 12:24:42 [-0300], Rafael Folco wrote:
> > so core 3 has min 33ns and max 129ns while 1us on average?
> Yes, because avg rounds up.
> There are some other potential fixes coming like:
> - stop rounding up avg
> - splitting bucket 001 (us) which is bigger (0 - 1.99999)
> - adding the max bucket to the end (do not limit to 32us)
> 
> ... but these are out of scope for this change. 

I'm not totally against floating point numbers here but you should add
the bullet numbers to your patch description. Also you might lose
precision over time if you deal with floating point.

However what you just showed me looks like the statistics part is
working right. I mean max lower than average. At least it is above min.

> Folco

Sebastian




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux