On Fri, 2024-12-20 at 13:07 -0500, John Kacur wrote: > > On Fri, 13 Dec 2024, ende.tan@xxxxxxxxxxxxxxxx wrote: > > > From: Tan En De <ende.tan@xxxxxxxxxxxxxxxx> > > > > Mark unused parameters with `__attribute__((unused))`. > > You were probably trying to be consistent with the rest of the programs in > rt-tests, however, according to checkpatch, > > WARNING: __always_unused or __maybe_unused is preferred over > __attribute__((__unused__)) > > __always_unused is slightly shorter, shall we try that instead? Checkpatch isn't perfect even when used on kernel sources, but should be taken with quite a few grains of salt when used with other projects. Failing to use a macro that doesn't even exist in rt-tests is a bit more than "trying to be consistent" :-P -Crystal
