Re: [1/1] rt-tests: cyclictest: Suppress unused parameter warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2024-12-20 at 13:02 -0500, John Kacur wrote:
> 
> On Fri, 13 Dec 2024, Crystal Wood wrote:
> 
> > On Fri, 2024-12-13 at 00:24 +0800, ende.tan@xxxxxxxxxxxxxxxx wrote:
> > > From: Tan En De <ende.tan@xxxxxxxxxxxxxxxx>
> > > 
> > > Mark unused parameters with `__attribute__((unused))`.
> > > 
> > > Signed-off-by: Tan En De <ende.tan@xxxxxxxxxxxxxxxx>
> > > ---
> > >  src/cyclictest/cyclictest.c | 4 ++--
> > >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > Can we just turn off this warning?  Unused parameters are entirely
> > normal in functions used as callbacks as well as with ifdefs, and it
> > seems like a low value warning to begin with (there's a reason it's not
> > in -Wall).
> 
> I believe it IS in -Wall
> https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html

-Wunused-parameter is in -Wextra, as per that link.  It's a crappy
warning that just causes noise to suppress all over the place.  The
kernel doesn't enable this warning, FWIW.

-Crystal






[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux