Hi Ulf,
On Tue, Aug 20, 2024 at 10:58 AM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> On Tue, 20 Aug 2024 at 10:55, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > On Mon, May 27, 2024 at 4:27 PM Ulf Hansson <ulf.hansson@xxxxxxxxxx> wrote:
> > > Using kobject_get_path() means a dynamic memory allocation gets done, which
> > > doesn't work on a PREEMPT_RT based configuration while holding genpd's raw
> > > spinlock.
> > >
> > > To fix the problem, let's convert into using the simpler dev_name(). This
> > > means the information about the path doesn't get presented in debugfs, but
> > > hopefully this shouldn't be an issue.
> > >
> > > Signed-off-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx>
> > > ---
> > > Changes in v2:
> > > - New patch.
> >
> > Thanks for your patch, which is now commit 9094e53ff5c86ebe ("pmdomain:
> > core: Use dev_name() instead of kobject_get_path() in debugfs")
> > in pmdomain/next.
> >
> > > --- a/drivers/pmdomain/core.c
> > > +++ b/drivers/pmdomain/core.c
> > > @@ -3215,16 +3214,9 @@ static int genpd_summary_one(struct seq_file *s,
> > > }
> > >
> > > list_for_each_entry(pm_data, &genpd->dev_list, list_node) {
> > > - kobj_path = kobject_get_path(&pm_data->dev->kobj,
> > > - genpd_is_irq_safe(genpd) ?
> > > - GFP_ATOMIC : GFP_KERNEL);
> > > - if (kobj_path == NULL)
> > > - continue;
> > > -
> > > - seq_printf(s, "\n %-50s ", kobj_path);
> > > + seq_printf(s, "\n %-50s ", dev_name(pm_data->dev));
> >
> > While some of the old names didn't even fit in 50 characters, the new
> > names need much less space, so perhaps this is a good opportunity to
> > decrease the table width?
>
> Sure, it seems reasonable! Do you want to send a patch?
I started looking into it. Then I noticed that on some systems
(e.g. TI am335x) the device names may have a longer format than
the typical <unit-address>.<nodename>. So I wanted to verify on
BeagleBone Black, but recent kernels crash during early boot.
Apparently that platform was broken between v6.8 and v6.9-rc1.
And during bisection, I encountered 3 different failure modes...
To be continued...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
