We would like to be able to set the cstates of CPUs while running
rteval.
This patch adds the file cpupower.py and options '--idle-set' and '--cpulist'
within rteval to use cpupower.
cpupower.py provides the infrastructure to interface with the cpupower
command, and the options in rteval-cmd let the user specify the cstate to be set
and the CPUs to set it on.
Signed-off-by: Anubhav Shelat <ashelat@xxxxxxxxxx>
---
rteval-cmd | 16 ++++++++-
rteval/cpupower.py | 85 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 100 insertions(+), 1 deletion(-)
create mode 100644 rteval/cpupower.py
diff --git a/rteval-cmd b/rteval-cmd
index 5cb6d7a44523..d9bf16838b6d 100755
--- a/rteval-cmd
+++ b/rteval-cmd
@@ -29,6 +29,7 @@ from rteval.Log import Log
from rteval import RtEval, rtevalConfig
from rteval.modules.loads import LoadModules
from rteval.modules.measurement import MeasurementModules
+from rteval import cpupower
from rteval.version import RTEVAL_VERSION
from rteval.systopology import SysTopology, parse_cpulist_from_config
from rteval.modules.loads.kcompile import ModuleParameters
@@ -146,7 +147,11 @@ def parse_options(cfg, parser, cmdargs):
parser.add_argument("-S", "--source-download", nargs="*", dest="rteval___srcdownload",
type=str, default=None, metavar="KERNEL_VERSION",
help='download a source kernel from kernel.org and exit')
-
+ parser.add_argument("-c", "--cpulist", dest="rteval___cpulist", metavar="CPULIST",
+ default=str([i for i in range(os.cpu_count())]).strip('[]'),
+ help='specify list of cpus whose idle state to modify')
+ parser.add_argument('--idle-set', dest='rteval___cstate', metavar='CSTATE',
+ default=None, help='cstate to enable for this rteval run')
if not cmdargs:
cmdargs = ["--help"]
@@ -394,6 +399,11 @@ if __name__ == '__main__':
if not os.path.isdir(rtevcfg.workdir):
raise RuntimeError(f"work directory {rtevcfg.workdir} does not exist")
+ # if idle-set has been specified, enable idlestate in rtecfg.cpulist
+ cpupower_controller = None
+ if rtevcfg.cstate:
+ cpupower_controller = cpupower.Cpupower(rtevcfg.cpulist, rtevcfg.cstate)
+ cpupower_controller.enable_idle_state()
rteval = RtEval(config, loadmods, measuremods, logger)
rteval.Prepare(rtevcfg.onlyload)
@@ -413,6 +423,10 @@ if __name__ == '__main__':
ec = rteval.Measure()
logger.log(Log.DEBUG, f"exiting with exit code: {ec}")
+ # reset idlestate
+ if rtevcfg.cstate:
+ cpupower_controller.restore_cstate()
+
sys.exit(ec)
except KeyboardInterrupt:
sys.exit(0)
diff --git a/rteval/cpupower.py b/rteval/cpupower.py
new file mode 100644
index 000000000000..da869420eb6f
--- /dev/null
+++ b/rteval/cpupower.py
@@ -0,0 +1,85 @@
+#! /user/bin/python3
+
+import subprocess
+import argparse
+import os
+import multiprocessing
+import time
+
+
+class Cpupower:
+ def __init__(self, cpulist, cstate):
+ self.cpulist = cpulist
+ self.cstate = cstate
+ self.nstates = len(os.listdir('/sys/devices/system/cpu/cpu0/cpuidle/')) # number of cstates
+ self.cpu_count = multiprocessing.cpu_count()
+ self.cstate_cfg = []
+
+
+ def enable_idle_state(self):
+ ''' Enable a specific cstate, while disabling all other cstates, and save the current cstate configuration '''
+ self.cstate_cfg = self.get_cstate_cfg()
+
+ # enable cstate and disable the rest
+ if (self.cpulist):
+ subprocess.run(['sudo', 'cpupower', '-c', self.cpulist,'idle-set', '-e', str(self.cstate)], stdout=open(os.devnull, 'wb'))
+ for cs in range(self.nstates):
+ if str(cs) != self.cstate:
+ subprocess.run(['sudo', 'cpupower', '-c', self.cpulist,'idle-set', '-d', str(cs)], stdout=open(os.devnull, 'wb'))
+ else:
+ subprocess.run(['sudo', 'cpupower', 'idle-set', '-e', str(self.cstate)], stdout=open(os.devnull, 'wb'))
+ for cs in range(self.nstates):
+ if str(cs) != self.cstate:
+ subprocess.run(['sudo', 'cpupower', 'idle-set', '-d', str(cs)], stdout=open(os.devnull, 'wb'))
+
+ if self.cpulist: print(f'Idlestate {self.cstate} enabled on CPUs {self.cpulist}')
+ else: print(f'Idlestate {self.cstate} enabled on all CPUs')
+
+
+ def get_cstate_cfg(self):
+ ''' Store the current cstate config '''
+ # cstate [m] configuration on cpu [n] can be found in '/sys/devices/system/cpu/cpu*/cpuidle/state*/disable'
+ cfg = []
+ for cpu in range(self.cpu_count):
+ cfg.append([])
+ for cs in range(self.nstates):
+ f = open('/sys/devices/system/cpu/cpu'+str(cpu)+'/cpuidle/state'+str(cs)+'/disable', 'r')
+ d = f.read(1)
+ cfg[cpu].append(d) # cstate_cfg[n][m] stores the m-th idle state on the n-th cpu
+
+ return cfg
+
+
+ def restore_cstate(self):
+ for cpu in range(self.cpu_count):
+ for cs in range(self.nstates):
+ f = open('/sys/devices/system/cpu/cpu'+str(cpu)+'/cpuidle/state'+str(cs)+'/disable', 'w')
+ f.write(self.cstate_cfg[cpu][cs])
+ f.close()
+ print('Idle state configuration restored')
+
+ def get_idle_info():
+ subprocess.call(['cpupower', 'idle-info'])
+
+
+if __name__ == '__main__':
+ parser = argparse.ArgumentParser()
+ parser.add_argument('-c', '--cpu-list', required=False, default=None,
+ help='List of cpus to perform cpupower-idle-set operation on.')
+ parser.add_argument('-s', '--cstate', default='',
+ help='Specify cstate to enable/disable')
+ parser.add_argument('--info', default=False, action='store_true', help='Get idle state information')
+
+ args = parser.parse_args()
+ print(args)
+ cpulist = args.cpu_list
+ cstate = args.cstate
+ if (cstate):
+ cpupower = Cpupower(cpulist, cstate)
+ cpupower.enable_idle_state()
+ time.sleep(10)
+ cpupower.restore_cstate()
+ elif (args.info):
+ Cpupower.get_idle_info()
+
+
--
2.45.2
