On Mon, 2024-05-20 at 00:28 +0200, Diederik de Haas wrote: > On Friday, 17 May 2024 15:08:36 CEST Diederik de Haas wrote: > > In file included from > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/in > > clude/linux/rwsem.h:15, from > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/in > > clude/linux/notifier.h:15, from > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/in > > clude/linux/clk.h:14, from > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/dr > > ivers/pinctrl/renesas/pinctrl-rzg2l.c:10: > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/dr > > ivers/pinctrl/renesas/pinctrl-rzg2l.c: In function ‘rzg2l_gpio_irq_restore’: > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/dr > > ivers/pinctrl/renesas/pinctrl-rzg2l.c:2072:52: error: ‘spinlock_t’ {aka > > ‘struct spinlock’} has no member named ‘rlock’; did you mean ‘lock’? 2072 | > > raw_spin_lock_irqsave(&pctrl->lock.rlock, flags); > > | ^~~~~ > > > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/inc > > lude/linux/spinlock.h:244:48: note: in definition of macro > > ‘raw_spin_lock_irqsave’ 244 | flags = > > _raw_spin_lock_irqsave(lock); \ > > > > | ^~~~ > > > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/dri > > vers/pinctrl/renesas/pinctrl-rzg2l.c:2076:57: error: ‘spinlock_t’ {aka > > ‘struct spinlock’} has no member named ‘rlock’; did you mean ‘lock’? 2076 | > > raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags); > > | ^~~~~ > > > > /home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/inc > > lude/linux/spinlock.h:282:45: note: in definition of macro > > ‘raw_spin_unlock_irqrestore’ 282 | > > _raw_spin_unlock_irqrestore(lock, flags); \ > > | ^~~~ > > > > make[8]: *** > > [/home/diederik/dev/debian/salsa/kernel-team/linux/debian/build/source_rt/s > > cripts/Makefile.build:249: drivers/pinctrl/renesas/pinctrl-rzg2l.o] Error 1 > > https://salsa.debian.org/kernel-team/linux/-/merge_requests/1081#note_492742 > pointed me to the following 2 commits which got added in 6.9-rc7: > > https://git.kernel.org/linus/aa43c15a790cf083a6e6a7c531cffd27a5e1fd4f > https://git.kernel.org/linus/02cd2d3be1c31a3fd328ee83e576340d34bc57d9 > > I'm inclined to think those are very relevant, but I don't know enough > about this material to be sure. Yeah, they're relevant/broken. pctrl->lock is a spinlock_t, which maps to an rtmutex for RT and a raw_spinlock for !RT specifically to allow seamless underlying lock type substitution via .config. -Mike