On Wed, 3 Apr 2024, Crystal Wood wrote: > On Tue, 2024-04-02 at 15:07 -0400, John Kacur wrote: > > > > > > On Mon, 4 Mar 2024, Crystal Wood wrote: > > > > > We only ever do out-of-tree builds, so the kernel directory should not > > > be > > > getting damaged except by incomplete extraction (which mrproper would > > > probably not fix) or external meddling. So, skip the mrproper and > > > instead re-extract if a "make clean" fails. > > > > > > Also, add -j to cleancmd to further speed things up. Startup speed may > > > not seem all that important given how long rteval is typically run for, > > > but this helps make quick tests (e.g. while debugging things, or when > > > hunting a latency that shows up very quickly) less painful. > > > > > > On my 12-cpu laptop, this patch saves about 15 seconds of startup time. > > > > > > Signed-off-by: Crystal Wood <crwood@xxxxxxxxxx> > > > You would probably achieve close to the same or better by just using '-j' > > with make mrproper > > Perhaps it would be almost as fast, depending on the system you're running > it on (and how many non-isolated cores it has). But it really doesn't seem > necessary. > > As for better, how? We're going from mrproper *and* clean to just clean. > The re-extraction only happens if clean fails. > We already reextract if we're in a state that is broken. Perhaps you're right and the mrproper isn't necessary, but perhaps I have a long memory of when we just did this by default and a lot of problems went away. Maybe I'm just stubborn. It seems like an "if it ain't broke don't fix it" problem to me, especially since your other patches already shortened the time for very short development runs. If you'd like to send a patch to add '-j' to this I would except that, otherwise, let's move on to some more interesting problems. John
