On 03.04.2024 17:22:52, Esben Haabendal wrote: > Busy polling with readl() is a rather harsh way to wait for a potentially > long time. This read_poll_timeout_atomic() is compiled to an imx_uart_readl()/udelay()/cpu_relax() loop. Does the introduction of udelay() bring any advantages? > While there, introduce a 10 ms timeout on this waiting, similar to what > many other serial drivers do. But you don't handle the return value... > Signed-off-by: Esben Haabendal <esben@xxxxxxxxxx> regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917-129 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Attachment:
signature.asc
Description: PGP signature
