On 2024-04-03, Esben Haabendal <esben@xxxxxxxxxx> wrote: >> Finally, if someone wanted to try porting another driver for PREEMPT_RT >> (for example, the imx serial console), I would certainly be interested >> in reviewing and integrating the patches for the PREEMPT_RT tree. > > Sounds good. I have looked at porting imx uart driver to nbcon, and have > something working now. It does smell quite a lot of copy-paste > behaviour, but I will send it as an RFC for you to see when I have > tested it a bit more. Great! > The write_thread and write_atomic functions share quite a lot of code, > carrying half of the copy-paste smell. > The other half is the inner loop of the write_thread function, which is > almost identical in 8250 and imx drivers. > > I guess there is room to refactor this to avoid this amount of > copy-paste before starting mass-porting. I certainly hope so. So far my 8250 work has been making sure it is technically reliable. I expect there can be a lot of improvement to make it more efficient and generic. John
