Re: [PATCH 1/4] rt-tests: Fix warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 18 Dec 2023, Crystal Wood wrote:

> On Thu, 2023-12-14 at 10:48 -0500, John Kacur wrote:
> > 
> > I tested this with rteval, and it works fine
> > checkpatch in the linux kernel flags a few minor things.
> > Would you mind fixing those up before I apply the patch?
> > 
> > WARNING: Improper SPDX comment style for 'src/include/histogram.h', please
> > use '/*' instead
> > #227: FILE: src/include/histogram.h:1:
> > +// SPDX-License-Identifier: GPL-2.0-or-later
> > 
> > (Yes, I know there are other files in rt-tests that also aren't using
> > the recommended commenting style, you probably copied from there.)
> 
> This confused me for quite a bit, until I saw in
> Documentation/process/license-rules.rst that *sources* get // but *headers*
> get /*.  The rationale seems to be based on the behavior of old toolchains
> when processing assembly code, linker scripts, etc.  Doesn't seem terribly
> relevant to non-kernel projects...
> 
> I can still "fix" it if you want.
> 
> 
> > 
> > ERROR: trailing whitespace
> > #338: FILE: src/lib/histogram.c:64:
> > +^I^I$
> 
> One of these days I need to teach the joe editor not to do this...
> 
> -Crystal
> 
> 
> 
No, your explanation works for me! Just fix the warnings about
the brace styles and I'll apply it.

John





[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux