On Fri, 2022-12-09 at 20:03 -0500, John Kacur wrote:
>
>
> On Thu, 8 Dec 2022, Crystal Wood wrote:
>
>
> >
> > @@ -677,6 +699,20 @@ static void parse_options(int argc, char *argv[])
> > exit(1);
> > }
> > break;
> > + case OPT_BUCKETWIDTH:
> > + case 'W':
> > + g.bucket_width = strtol(optarg, NULL, 10);
> > + if (g.bucket_size <= 0) {
>
> I think this should be g.bucket_width
Oops
>
> A quick first look through and run, see the one comment above
> near "case 'W'"
>
> and then
>
> checkpatch reports some minor easily fixed problems
>
> ../linux/scripts/checkpatch.pl oslat.patch
> ERROR: code indent should use tabs where possible
> #100: FILE: src/oslat/oslat.c:342:
> +^I^I g.precision, us);$
>
> ERROR: code indent should use tabs where possible
> #102: FILE: src/oslat/oslat.c:344:
> +^I^I g.precision, us);$
I was matching the existing style in the file that tended to use spaces for
alignment.
> ERROR: spaces required around that '=' (ctx:VxV)
> #227: FILE: src/oslat/oslat.c:654:
> + OPT_BUCKETSIZE=1, OPT_BUCKETWIDTH, OPT_CPU_LIST,
> OPT_CPU_MAIN_THREAD,
> ^
I only added OPT_BUCKETWIDTH to the list; I didn't touch the =1 part.
-Scott
